Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix incorrect usage of ok_or with anyhow #11589

Merged
merged 3 commits into from
Aug 10, 2023
Merged

fix: fix incorrect usage of ok_or with anyhow #11589

merged 3 commits into from
Aug 10, 2023

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Aug 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #11580 #11445

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions bot added the type/fix Bug fix label Aug 10, 2023
StrikeW
StrikeW approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@codecov
Copy link

codecov bot commented Aug 10, 2023 •
edited
Loading

Codecov Report

Merging #11589 (fd2c565) into main (0f4fdb5) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 23.07%.

@@           Coverage Diff           @@
##             main   #11589   +/-   ##
=======================================
  Coverage   70.32%   70.33%           
=======================================
  Files        1359     1359           
  Lines      226925   226929    +4     
=======================================
+ Hits       159580   159600   +20     
+ Misses      67345    67329   -16
Flag Coverage Δ
rust 70.33% <23.07%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/common/src/system_param/mod.rs 84.35% <0.00%> (ø)
src/connector/src/sink/clickhouse.rs 0.00% <0.00%> (ø)
src/connector/src/sink/coordinate.rs 0.00% <0.00%> (ø)
src/connector/src/source/kafka/private_link.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/create_connection.rs 0.00% <0.00%> (ø)
src/frontend/src/session.rs 30.53% <0.00%> (-0.08%) ⬇️
src/meta/src/rpc/cloud_provider.rs 0.00% <0.00%> (ø)
src/sqlparser/src/ast/statement.rs 43.12% <0.00%> (ø)
...c/stream/src/executor/source/fs_source_executor.rs 0.00% <0.00%> (ø)
src/stream/src/executor/source/source_executor.rs 85.41% <0.00%> (ø)
... and 5 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wenym1 wenym1 enabled auto-merge August 10, 2023 08:07
@wenym1 wenym1 added this pull request to the merge queue Aug 10, 2023
Merged via the queue into main with commit 2342e8b Aug 10, 2023
@wenym1 wenym1 deleted the yiming/fix-anyhow branch August 10, 2023 09:35
@wenym1 wenym1 mentioned this pull request Aug 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StrikeW StrikeW StrikeW approved these changes

@hzxa21 hzxa21 hzxa21 approved these changes

@xiangjinwu xiangjinwu Awaiting requested review from xiangjinwu

Assignees
No one assigned
Labels
type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: avoid using ok_or(anyhow!(...))
3 participants
@wenym1 @hzxa21 @StrikeW